From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 26 Jun 2015 19:21:16 +0000 (+0200)
Subject: tc1100-wmi: Delete an unnecessary check before the function call "kfree"
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=0d44b410a01a75daff60ce4cb78313135cdb3649;p=deliverable%2Flinux.git

tc1100-wmi: Delete an unnecessary check before the function call "kfree"

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---

diff --git a/drivers/platform/x86/tc1100-wmi.c b/drivers/platform/x86/tc1100-wmi.c
index e36542564131..89aa976f0ab2 100644
--- a/drivers/platform/x86/tc1100-wmi.c
+++ b/drivers/platform/x86/tc1100-wmi.c
@@ -82,7 +82,7 @@ static int get_state(u32 *out, u8 instance)
 		tmp = 0;
 	}
 
-	if (result.length > 0 && result.pointer)
+	if (result.length > 0)
 		kfree(result.pointer);
 
 	switch (instance) {