From: H Hartley Sweeten Date: Thu, 12 Apr 2012 20:44:20 +0000 (-0700) Subject: mm: page-writeback.c: local functions should not be exposed globally X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=18cf8cf8bab1296f477ee4dd8f78b5b23c5a192e;p=deliverable%2Flinux.git mm: page-writeback.c: local functions should not be exposed globally The function global_dirtyable_memory is only referenced in this file and should be marked static to prevent it from being exposed globally. This quiets the sparse warning: warning: symbol 'global_dirtyable_memory' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Signed-off-by: Fengguang Wu --- diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 26adea8ca2e7..9dec97fee375 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -204,7 +204,7 @@ static unsigned long highmem_dirtyable_memory(unsigned long total) * Returns the global number of pages potentially available for dirty * page cache. This is the base value for the global dirty limits. */ -unsigned long global_dirtyable_memory(void) +static unsigned long global_dirtyable_memory(void) { unsigned long x;