From: Philippe Proulx <eeppeliteloop@gmail.com>
Date: Fri, 9 Aug 2019 18:44:44 +0000 (-0400)
Subject: Fix: argpar.c: logically dead code
X-Git-Tag: v2.0.0-rc1~337
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=1c18d2279f2496cd153dc8f4bc88540824b76f0d;p=babeltrace.git

Fix: argpar.c: logically dead code

Found by Coverity Scan.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: Id67092bcdb0a0ebf7aa29186668457596c177ca6
---

diff --git a/src/argpar/argpar.c b/src/argpar/argpar.c
index fe78a008..d3451207 100644
--- a/src/argpar/argpar.c
+++ b/src/argpar/argpar.c
@@ -64,7 +64,7 @@ struct bt_argpar_item_opt *create_opt_item(
 
 	if (arg) {
 		opt_item->arg = g_strdup(arg);
-		if (!opt_item) {
+		if (!opt_item->arg) {
 			goto error;
 		}
 	}