From: Vasiliy Kulikov <segooon@gmail.com>
Date: Tue, 28 Sep 2010 17:08:04 +0000 (+0400)
Subject: staging: otus: use free_netdev(netdev) instead of kfree()
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=2166abebc55843409327ddf6cc424cafadd33a30;p=deliverable%2Flinux.git

staging: otus: use free_netdev(netdev) instead of kfree()

Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

@@
struct net_device* dev;
@@

-kfree(dev)
+free_netdev(dev)

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/otus/usbdrv.c b/drivers/staging/otus/usbdrv.c
index 165a82b9ab85..9a5c4152aac4 100644
--- a/drivers/staging/otus/usbdrv.c
+++ b/drivers/staging/otus/usbdrv.c
@@ -690,7 +690,7 @@ void usbdrv_clear_structs(struct net_device *dev)
 
     kfree(macp);
 
-    kfree(dev);
+    free_netdev(dev);
 
 }