From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Tue, 15 Oct 2013 17:23:33 +0000 (-0400)
Subject: Fix: Uninitialized ctf_stream_pos structure in ctf_float_write()
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=27611b66503a0c7f8bcb4a1be285e78d4f9cdbe3;p=deliverable%2Fbabeltrace.git

Fix: Uninitialized ctf_stream_pos structure in ctf_float_write()

This structure is passed to _ctf_float_copy() which uses the
uninitialized mmap_offset and offset values to read the source
floating point value.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/formats/ctf/types/float.c b/formats/ctf/types/float.c
index 2daadf91e..689028360 100644
--- a/formats/ctf/types/float.c
+++ b/formats/ctf/types/float.c
@@ -232,7 +232,7 @@ int ctf_float_write(struct bt_stream_pos *ppos, struct bt_definition *definition
 	union doubleIEEE754 u;
 	struct bt_definition *tmpdef;
 	struct definition_float *tmpfloat;
-	struct ctf_stream_pos srcp;
+	struct ctf_stream_pos srcp = { { 0 } };
 	struct mmap_align mma;
 	int ret;