From: Christian Engelmayer Date: Wed, 7 May 2014 19:45:52 +0000 (+0200) Subject: staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=27a2234edd4a5c8b0ebdaaa3f6a5f00183f3154f;p=deliverable%2Flinux.git staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach() This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable 'has_dio' is set accordingly. Otherwise it is left uninitialized and the following subdevice instantiation depends on the stack. Detected by Coverity - CID 1077830. Signed-off-by: Christian Engelmayer Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/ii_pci20kc.c b/drivers/staging/comedi/drivers/ii_pci20kc.c index 3558ab3b6e1f..2516ce834839 100644 --- a/drivers/staging/comedi/drivers/ii_pci20kc.c +++ b/drivers/staging/comedi/drivers/ii_pci20kc.c @@ -461,6 +461,7 @@ static int ii20k_attach(struct comedi_device *dev, id = readb(devpriv->ioaddr + II20K_ID_REG); switch (id & II20K_ID_MASK) { case II20K_ID_PCI20001C_1A: + has_dio = false; break; case II20K_ID_PCI20001C_2A: has_dio = true;