From: Andrew Cagney Date: Sun, 12 Sep 2004 16:13:04 +0000 (+0000) Subject: 2004-09-12 Andrew Cagney X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=2bfb72ee0679082ba87dfbfc63561a281acee408;p=deliverable%2Fbinutils-gdb.git 2004-09-12 Andrew Cagney * valprint.c (print_longest): Use fputs_filtered. Make "val" const. * Makefile.in (valprint.o): Delete explict rule. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 649d07b57f..389dc0de2e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2004-09-12 Andrew Cagney + * valprint.c (print_longest): Use fputs_filtered. Make "val" + const. + * Makefile.in (valprint.o): Delete explict rule. + * config/m68k/nbsdelf.mh: Add missing trailing newline. Problem reported by Dave Anderson. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index cf29fade1c..a8fcd7321b 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1465,12 +1465,6 @@ v850ice.o: $(srcdir)/v850ice.c $(GDBTK_CFLAGS) \ $(srcdir)/v850ice.c -# FIXME: cagney/2003-08-10: Do not try to build "valprint.c" with -# -Wformat-nonliteral. It relies on local_hex_format et.al. and -# that's a mess. It needs a serious overhaul. -valprint.o: $(srcdir)/valprint.c - $(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) $(srcdir)/valprint.c - # Message files. Based on code in gcc/Makefile.in. diff --git a/gdb/valprint.c b/gdb/valprint.c index 64216f85f0..fd92750b8c 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -230,7 +230,8 @@ void print_longest (struct ui_file *stream, int format, int use_c_format, LONGEST val_long) { - char *val; + const char *val; + switch (format) { case 'd': @@ -253,8 +254,7 @@ print_longest (struct ui_file *stream, int format, int use_c_format, default: internal_error (__FILE__, __LINE__, "failed internal consistency check"); } - - fprintf_filtered (stream, val); + fputs_filtered (val, stream); } /* This used to be a macro, but I don't think it is called often enough