From: Dan Carpenter <error27@gmail.com>
Date: Sat, 13 Nov 2010 08:24:22 +0000 (+0300)
Subject: Staging: bcm: signedness bug in InitCardAndDownloadFirmware()
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=2e3161390130f50fdbb4b989c667f42e5008107f;p=deliverable%2Flinux.git

Staging: bcm: signedness bug in InitCardAndDownloadFirmware()

status is used to store negative error codes throughout.  The only place
where this is a runtime bug is if create_worker_threads() fails.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 023c511c0001..9588fbe101d9 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -1079,7 +1079,7 @@ int run_card_proc(PMINI_ADAPTER ps_adapter )
 int InitCardAndDownloadFirmware(PMINI_ADAPTER ps_adapter)
 {
 
-	UINT status = STATUS_SUCCESS;
+	int status;
 	UINT value = 0;
 	/*
  	 * Create the threads first and then download the