From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Fri, 18 Mar 2022 14:58:03 +0000 (-0400)
Subject: Fix: lttng-elf: wrong error label used by error path
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=3308655a7e594e7d8e59146f77f18a767599538d;p=deliverable%2Flttng-tools.git

Fix: lttng-elf: wrong error label used by error path

1486805 Resource leak
The system resource will not be reclaimed and reused, reducing the future availability of the resource.

In lttng_elf_get_symbol_offset: Leak of memory or pointers to system resources (CWE-404)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I78b868773b389c2eaf3f1d45151fe9416b1fe447
---

diff --git a/src/common/lttng-elf.cpp b/src/common/lttng-elf.cpp
index 711447203..23d5cb7f0 100644
--- a/src/common/lttng-elf.cpp
+++ b/src/common/lttng-elf.cpp
@@ -827,7 +827,7 @@ int lttng_elf_get_symbol_offset(int fd, char *symbol, uint64_t *offset)
 	if (symtab_hdr.sh_entsize == 0) {
 		DBG("Invalid ELF string table entry size.");
 		ret = LTTNG_ERR_ELF_PARSING;
-		goto free_symbol_table_data;
+		goto free_string_table_data;
 	}
 
 	sym_count = symtab_hdr.sh_size / symtab_hdr.sh_entsize;