From: Wei Yongjun Date: Mon, 29 Apr 2013 23:21:07 +0000 (-0700) Subject: drivers/rtc/rtc-pcf2123.c: fix error return code in pcf2123_probe() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=35623715818dfa720cccf99cd280dcbb4b78da23;p=deliverable%2Flinux.git drivers/rtc/rtc-pcf2123.c: fix error return code in pcf2123_probe() Fix to return -ENODEV in the chip not found error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Cc: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 6a3f329c3df4..796a6c5067dd 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -266,6 +266,7 @@ static int pcf2123_probe(struct spi_device *spi) if (!(rxbuf[0] & 0x20)) { dev_err(&spi->dev, "chip not found\n"); + ret = -ENODEV; goto kfree_exit; }