From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 19 Sep 2012 06:27:00 +0000 (+0100)
Subject: iio: dac/ad5755: signedness bug in ad5755_setup_pdata()
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=369d0e20138c774e4c0c07ca1572e412207bc3fc;p=deliverable%2Flinux.git

iio: dac/ad5755: signedness bug in ad5755_setup_pdata()

We need "ret" to be signed for the error handling to work correctly.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index e6dbe5ff7e5a..5db3506034c5 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev,
 	const struct ad5755_platform_data *pdata)
 {
 	struct ad5755_state *st = iio_priv(indio_dev);
-	unsigned int ret;
 	unsigned int val;
 	unsigned int i;
+	int ret;
 
 	if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE ||
 		pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ ||