From: Markus Elfring Date: Tue, 3 Nov 2015 17:18:37 +0000 (+0100) Subject: irda: Delete an unnecessary check before the function call "irlmp_unregister_service" X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=37b8e1ca0fd7adce1c75b5d95e5515bd2dc234dd;p=deliverable%2Flinux.git irda: Delete an unnecessary check before the function call "irlmp_unregister_service" The irlmp_unregister_service() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller --- diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c index fae6822cc367..e6aa48b5395c 100644 --- a/net/irda/af_irda.c +++ b/net/irda/af_irda.c @@ -2123,8 +2123,7 @@ static int irda_setsockopt(struct socket *sock, int level, int optname, } /* Unregister any old registration */ - if (self->skey) - irlmp_unregister_service(self->skey); + irlmp_unregister_service(self->skey); self->skey = irlmp_register_service((__u16) opt); break;