From: Sachin Kamat Date: Fri, 14 Feb 2014 11:49:47 +0000 (+0530) Subject: regulator: max77686: Use of_get_child_by_name X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=398a6616b5d9339043322f358d937688951c5e23;p=deliverable%2Flinux.git regulator: max77686: Use of_get_child_by_name of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c index ae001ccf26f4..0e725f6ed455 100644 --- a/drivers/regulator/max77686.c +++ b/drivers/regulator/max77686.c @@ -400,7 +400,7 @@ static int max77686_pmic_dt_parse_pdata(struct platform_device *pdev, unsigned int i; pmic_np = iodev->dev->of_node; - regulators_np = of_find_node_by_name(pmic_np, "voltage-regulators"); + regulators_np = of_get_child_by_name(pmic_np, "voltage-regulators"); if (!regulators_np) { dev_err(&pdev->dev, "could not find regulators sub-node\n"); return -EINVAL;