From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 3 Dec 2014 05:55:53 +0000 (-0800)
Subject: Input: lm8323 - missing error check in lm8323_set_disable()
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=3b5005e9206af245033e9209eee193f3d7b2f636;p=deliverable%2Flinux.git

Input: lm8323 - missing error check in lm8323_set_disable()

The missing error handling here is not especially harmful but static
checkers complain that "i" can be used uninitialized.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
index cb32e2b506b7..21bea52d4365 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -616,6 +616,8 @@ static ssize_t lm8323_set_disable(struct device *dev,
 	unsigned int i;
 
 	ret = kstrtouint(buf, 10, &i);
+	if (ret)
+		return ret;
 
 	mutex_lock(&lm->lock);
 	lm->kp_enabled = !i;