From: Simon Marchi <simon.marchi@efficios.com>
Date: Thu, 18 Apr 2024 14:36:22 +0000 (+0000)
Subject: ctf: rename ctx_create to ctf_visitor_generate_ir_create
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=3ca10a95a77cd126c7787831cb4ea8b90b09929a;p=babeltrace.git

ctf: rename ctx_create to ctf_visitor_generate_ir_create

There is an unnecessary level here, rename the existing ctx_create to
ctf_visitor_generate_ir_create.  Remove the existing
ctf_visitor_generate_ir_create.

Change-Id: I2ce578f30e1e9e25754dc9ad4f18610eb3a0be36
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/8424
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/12743
---

diff --git a/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp b/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp
index 4e186295..8e5cb296 100644
--- a/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp
+++ b/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp
@@ -464,16 +464,10 @@ ctf_visitor_generate_ir::~ctf_visitor_generate_ir()
     }
 }
 
-/**
- * Creates a new visitor context.
- *
- * @param trace	Associated trace
- * @returns	New visitor context, or NULL on error
- */
-static ctf_visitor_generate_ir::UP
-ctx_create(const ctf::src::ClkClsCfg clkClsCfg,
-           const bt2::OptionalBorrowedObject<bt2::SelfComponent> selfComp,
-           const bt2c::Logger& logger)
+ctf_visitor_generate_ir::UP
+ctf_visitor_generate_ir_create(const ctf::src::ClkClsCfg& clkClsCfg,
+                               const bt2::OptionalBorrowedObject<bt2::SelfComponent> selfComp,
+                               const bt2c::Logger& logger)
 {
     ctf_visitor_generate_ir::UP ctx =
         bt2s::make_unique<ctf_visitor_generate_ir>(clkClsCfg, selfComp, logger);
@@ -4401,29 +4395,6 @@ end:
     return ret;
 }
 
-ctf_visitor_generate_ir::UP
-ctf_visitor_generate_ir_create(const ctf::src::ClkClsCfg& clkClsCfg,
-                               const bt2::OptionalBorrowedObject<bt2::SelfComponent> selfComp,
-                               const bt2c::Logger& parentLogger)
-{
-    bt2c::Logger logger {parentLogger, "PLUGIN/CTF/META/IR-VISITOR"};
-
-    /* Create visitor's context */
-    ctf_visitor_generate_ir::UP ctx = ctx_create(clkClsCfg, selfComp, logger);
-    if (!ctx) {
-        BT_CPPLOGE_APPEND_CAUSE_SPEC(logger, "Cannot create visitor's context.");
-        goto error;
-    }
-
-    goto end;
-
-error:
-    ctx.reset();
-
-end:
-    return ctx;
-}
-
 bt2::TraceClass::Shared
 ctf_visitor_generate_ir_get_ir_trace_class(struct ctf_visitor_generate_ir *ctx)
 {