From: Johan Hovold <jhovold@gmail.com>
Date: Thu, 25 Oct 2012 11:35:10 +0000 (+0200)
Subject: USB: mos7840: fix port-device leak in error path
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=3eb55cc4ed88eee3b5230f66abcdbd2a91639eda;p=deliverable%2Flinux.git

USB: mos7840: fix port-device leak in error path

The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.

Cc: <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 35ad3f5c4c0e..c5e5a6c8d69e 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2587,7 +2587,6 @@ error:
 		kfree(mos7840_port->ctrl_buf);
 		usb_free_urb(mos7840_port->control_urb);
 		kfree(mos7840_port);
-		serial->port[i] = NULL;
 	}
 	return status;
 }