From: Vivek Goyal <vgoyal@in.ibm.com>
Date: Tue, 26 Sep 2006 08:52:27 +0000 (+0200)
Subject: [PATCH] kdump x86_64 nmi event notification fix
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=3f22c5789eb76fd9aabe4be37ba609c793f046f9;p=deliverable%2Flinux.git

[PATCH] kdump x86_64 nmi event notification fix

After a crash we should wait for NMI IPI event and not for external NMI or
NMI watchdog tick.

Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

diff --git a/arch/x86_64/kernel/crash.c b/arch/x86_64/kernel/crash.c
index 44c8af65325e..fc57a139123e 100644
--- a/arch/x86_64/kernel/crash.c
+++ b/arch/x86_64/kernel/crash.c
@@ -102,7 +102,7 @@ static int crash_nmi_callback(struct notifier_block *self,
 	struct pt_regs *regs;
 	int cpu;
 
-	if (val != DIE_NMI)
+	if (val != DIE_NMI_IPI)
 		return NOTIFY_OK;
 
 	regs = ((struct die_args *)data)->regs;
@@ -114,7 +114,7 @@ static int crash_nmi_callback(struct notifier_block *self,
 	 * an NMI if system was initially booted with nmi_watchdog parameter.
 	 */
 	if (cpu == crashing_cpu)
-		return 1;
+		return NOTIFY_STOP;
 	local_irq_disable();
 
 	crash_save_this_cpu(regs, cpu);