From: Vipin Kumar Date: Wed, 14 Mar 2012 06:17:12 +0000 (+0530) Subject: mtd: nand/fsmc: Initialize the badblockbits to 7 X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=467e6e7be2e26fd5bbaabd849717d37de99df8f1;p=deliverable%2Flinux.git mtd: nand/fsmc: Initialize the badblockbits to 7 Ideally, the block should have 0xff written on the bad block position. Any value other than 0xff implies a bad block. In practical situations, there can be bit flips in the oob area as well which means that a block with 0x7f being read at bad block position may imply a bad block but it is infact only a bit flip in the bad block byte. To resolve this problem, the block is marked as good if number of high bits is greater than or equal to badblockbits (initialized to 7) Signed-off-by: Vipin Kumar Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse --- diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c index 6a0bca17c223..91f5b3404c79 100644 --- a/drivers/mtd/nand/fsmc_nand.c +++ b/drivers/mtd/nand/fsmc_nand.c @@ -802,6 +802,7 @@ static int __init fsmc_nand_probe(struct platform_device *pdev) nand->ecc.size = 512; nand->options = pdata->options; nand->select_chip = fsmc_select_chip; + nand->badblockbits = 7; if (pdata->width == FSMC_NAND_BW16) nand->options |= NAND_BUSWIDTH_16;