From: Wei Yongjun Date: Tue, 7 May 2013 11:48:22 +0000 (+0800) Subject: usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=48ad20f32d1153ad6a0a95ad2bfc391daa13fcad;p=deliverable%2Flinux.git usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe() Fix to return a negative error code in the gpio_to_irq() error handling case instead of 0, as done elsewhere in this function. Reviewed-by: Jingoo Han Signed-off-by: Wei Yongjun Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 7f5e3a66d02a..09c4f70c93c4 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c @@ -1851,6 +1851,7 @@ static int s3c2410_udc_probe(struct platform_device *pdev) irq = gpio_to_irq(udc_info->vbus_pin); if (irq < 0) { dev_err(dev, "no irq for gpio vbus pin\n"); + retval = irq; goto err_gpio_claim; }