From: Casey Schaufler <casey@schaufler-ca.com>
Date: Thu, 19 Dec 2013 21:23:26 +0000 (-0800)
Subject: Smack: change rule cap check
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=4afde48be8929b6da63a9e977aaff0894ba82984;p=deliverable%2Flinux.git

Smack: change rule cap check

smk_write_change_rule() is calling capable rather than
the more correct smack_privileged(). This allows for setting
rules in violation of the onlycap facility. This is the
simple repair.

Targeted for git://git.gitorious.org/smack-next/kernel.git

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
---

diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index f5a6bb8e2828..3198cfe1dcc6 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -2152,7 +2152,7 @@ static ssize_t smk_write_change_rule(struct file *file, const char __user *buf,
 	/*
 	 * Must have privilege.
 	 */
-	if (!capable(CAP_MAC_ADMIN))
+	if (!smack_privileged(CAP_MAC_ADMIN))
 		return -EPERM;
 
 	return smk_write_rules_list(file, buf, count, ppos, NULL, NULL,