From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Tue, 5 Mar 2024 16:13:55 +0000 (-0500)
Subject: percpu: remove rseq_percpu_pool_ptr_offset
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=4f93105c023f687b84236d3388e0d316983e15fe;hp=d87b0cd222a1c11751be7f8b655fc0dc45b7dc12;p=librseq.git

percpu: remove rseq_percpu_pool_ptr_offset

The rseq_percpu_pool_ptr_offset API is now unused, and it leaks
implementation details about per-cpu pools which may prevent
implementing auto-extensible pools efficiently in the future.

Remove it.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Ib62c4af34c04f9c4e5227dab2f487356478b32fa
---

diff --git a/include/rseq/percpu-alloc.h b/include/rseq/percpu-alloc.h
index 95638af..5308d61 100644
--- a/include/rseq/percpu-alloc.h
+++ b/include/rseq/percpu-alloc.h
@@ -167,16 +167,6 @@ void rseq_percpu_free(void __rseq_percpu *ptr);
 void *__rseq_percpu_ptr(void __rseq_percpu *ptr, int cpu);
 #define rseq_percpu_ptr(ptr, cpu)	((__typeof__(*(ptr)) *) __rseq_percpu_ptr(ptr, cpu))
 
-/*
- * rseq_percpu_pool_cpu_offset: Return the offset from encoded to decoded percpu pointer.
- *
- * Calculate the offset from any __rseq_percpu pointer allocated from
- * the pool to its associated per-cpu data for @cpu.
- *
- * This API is MT-safe.
- */
-ptrdiff_t rseq_percpu_pool_ptr_offset(struct rseq_percpu_pool *pool, int cpu);
-
 /*
  * rseq_percpu_pool_set_create: Create a pool set.
  *
diff --git a/src/rseq-percpu-alloc.c b/src/rseq-percpu-alloc.c
index eced0f7..289ed84 100644
--- a/src/rseq-percpu-alloc.c
+++ b/src/rseq-percpu-alloc.c
@@ -124,14 +124,6 @@ void *__rseq_pool_percpu_ptr(struct rseq_percpu_pool *pool, int cpu, uintptr_t i
 	return pool->base + (pool->percpu_len * cpu) + item_offset;
 }
 
-ptrdiff_t rseq_percpu_pool_ptr_offset(struct rseq_percpu_pool *pool, int cpu)
-{
-	uintptr_t rseq_percpu_base = (uintptr_t) pool->index << POOL_INDEX_SHIFT;
-	uintptr_t refptr = (uintptr_t) __rseq_pool_percpu_ptr(pool, cpu, 0);
-
-	return (ptrdiff_t) (refptr - rseq_percpu_base);
-}
-
 void *__rseq_percpu_ptr(void __rseq_percpu *_ptr, int cpu)
 {
 	uintptr_t ptr = (uintptr_t) _ptr;