From: Philippe Proulx Date: Mon, 14 Mar 2016 19:39:51 +0000 (-0400) Subject: Fix: config: check PH "uuid" field's element type's signedness X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=5097a8331b6ef2a37dccdfb6d27037a49b9a0147;p=deliverable%2Fbarectf.git Fix: config: check PH "uuid" field's element type's signedness Signed-off-by: Philippe Proulx --- diff --git a/barectf/config.py b/barectf/config.py index bea8b7a..736b070 100644 --- a/barectf/config.py +++ b/barectf/config.py @@ -376,13 +376,16 @@ class _MetadataSpecialFieldsValidator: element_type = field_type.element_type if type(element_type) is not metadata.Integer: - raise ConfigError('"uuid" field in trace packet header type must be an array of 16 bytes') + raise ConfigError('"uuid" field in trace packet header type must be an array of 16 unsigned bytes') if element_type.size != 8: - raise ConfigError('"uuid" field in trace packet header type must be an array of 16 bytes') + raise ConfigError('"uuid" field in trace packet header type must be an array of 16 unsigned bytes') + + if element_type.signed: + raise ConfigError('"uuid" field in trace packet header type must be an array of 16 unsigned bytes') if element_type.align != 8: - raise ConfigError('"uuid" field in trace packet header type must be an array of 16 byte-aligned bytes') + raise ConfigError('"uuid" field in trace packet header type must be an array of 16 unsigned, byte-aligned bytes') def _validate_trace(self, meta): self._validate_trace_packet_header_type(meta.trace.packet_header_type)