From: Dan Carpenter <error27@gmail.com>
Date: Wed, 8 Apr 2009 22:44:04 +0000 (-0700)
Subject: niu: Fix error handling
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=58f3e0a864c46dadbeadf682e6bbdcab14ba19d3;p=deliverable%2Flinux.git

niu: Fix error handling

platform_device_register_simple() returns ERR_PTR(), not NULL, if an error
occurs.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 73cac6c78cb6..2cd6109b8586 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -9542,7 +9542,7 @@ static struct niu_parent * __devinit niu_new_parent(struct niu *np,
 
 	plat_dev = platform_device_register_simple("niu", niu_parent_index,
 						   NULL, 0);
-	if (!plat_dev)
+	if (IS_ERR(plat_dev))
 		return NULL;
 
 	for (i = 0; attr_name(niu_parent_attributes[i]); i++) {