From: Luis Ortega Date: Mon, 27 Jan 2014 20:27:49 +0000 (-0800) Subject: Input: zforce - remove unnecessary payload data checks X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=5aee41a60c4d53f65918c1ec0ab94c245f2c08af;p=deliverable%2Flinux.git Input: zforce - remove unnecessary payload data checks The function zforce_read_packet() reads 2 values (bytes) of payload header, validates them and then proceeds to read the payload body. The function stores all these in a u8 buffer. The PAYLOAD_LENGTH check seems to be trying to detect an overflow error. However, since we are just reading a u8 value from the buffer, these checks are unnecessary and we should simply compare against zero. Signed-off-by: Luis Ortega Acked-by: Heiko Stuebner Tested-by: Heiko Stuebner - bq Cervantes (imx6sl) Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/touchscreen/zforce_ts.c b/drivers/input/touchscreen/zforce_ts.c index e87888c229ab..3ed024985a58 100644 --- a/drivers/input/touchscreen/zforce_ts.c +++ b/drivers/input/touchscreen/zforce_ts.c @@ -423,7 +423,7 @@ static int zforce_read_packet(struct zforce_ts *ts, u8 *buf) goto unlock; } - if (buf[PAYLOAD_LENGTH] <= 0 || buf[PAYLOAD_LENGTH] > 255) { + if (buf[PAYLOAD_LENGTH] == 0) { dev_err(&client->dev, "invalid payload length: %d\n", buf[PAYLOAD_LENGTH]); ret = -EIO;