From: Beniamino Galvani <b.galvani@gmail.com>
Date: Mon, 5 May 2014 21:29:00 +0000 (+0200)
Subject: pwm: spear: fix check on pwmchip_add() return value
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=5b1e8e0653760ade53c0c7caaa9278c57361cb8b;p=deliverable%2Flinux.git

pwm: spear: fix check on pwmchip_add() return value

pwmchip_add() returns zero on success and a negative value on error,
so the condition of the check must be inverted.

Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---

diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
index b4f6d0df5f2d..cffa1e390320 100644
--- a/drivers/pwm/pwm-spear.c
+++ b/drivers/pwm/pwm-spear.c
@@ -220,7 +220,7 @@ static int spear_pwm_probe(struct platform_device *pdev)
 	}
 
 	ret = pwmchip_add(&pc->chip);
-	if (!ret) {
+	if (ret < 0) {
 		clk_unprepare(pc->clk);
 		dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
 	}