From: Andrew Burgess <andrew.burgess@embecosm.com>
Date: Wed, 24 Mar 2021 17:48:27 +0000 (+0000)
Subject: gdb: move cheap pointer equality check earlier in types_equal
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=5e18990f1f2957e59fa4b62d64ed0cb683b65b58;hp=5e18990f1f2957e59fa4b62d64ed0cb683b65b58;p=deliverable%2Fbinutils-gdb.git

gdb: move cheap pointer equality check earlier in types_equal

I noticed that in types equal we start with a cheap pointer equality
check, then resolve typedefs, then do a series of (semi-)expensive
checks, including checking type names, before, finally performing
another pointer equality check.

We should hoist the second pointer equality check to immediately after
we have resolved typedefs.  This would save performing the more
expensive checks.

This isn't going to give any noticable performance improvement, I just
spotted this in passing and figured I might as well commit the fix.

There should be no user visible changes after this commit.

gdb/ChangeLog:

	* gdbtypes.c (types_equal): Move pointer equality check earlier in
	the function.
---