From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Date: Tue, 19 May 2015 11:04:35 +0000 (-0300)
Subject: [media] cx24120: don't initialize a var that won't be used
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=65b01665a98a8738371d945230f4bd6fb41a3594;p=deliverable%2Flinux.git

[media] cx24120: don't initialize a var that won't be used

As reported by smatch:
drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  int ret, ficus;
      ^

The values written by cx24120 are never checked. So, remove the
check here too. That's said, the best would be to do the reverse,
but globally: to properly handle the error codes.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Patrick Boettcher <patrick.boettcher@posteo.de>
---

diff --git a/drivers/media/dvb-frontends/cx24120.c b/drivers/media/dvb-frontends/cx24120.c
index da50b9e1e9f8..3ab8582e233b 100644
--- a/drivers/media/dvb-frontends/cx24120.c
+++ b/drivers/media/dvb-frontends/cx24120.c
@@ -365,17 +365,17 @@ static void cx24120_check_cmd(struct cx24120_state *state, u8 id)
 static int cx24120_message_send(struct cx24120_state *state,
 				struct cx24120_cmd *cmd)
 {
-	int ret, ficus;
+	int ficus;
 
 	if (state->mpeg_enabled) {
 		/* Disable mpeg out on certain commands */
 		cx24120_check_cmd(state, cmd->id);
 	}
 
-	ret = cx24120_writereg(state, CX24120_REG_CMD_START, cmd->id);
-	ret = cx24120_writeregs(state, CX24120_REG_CMD_ARGS, &cmd->arg[0],
-				cmd->len, 1);
-	ret = cx24120_writereg(state, CX24120_REG_CMD_END, 0x01);
+	cx24120_writereg(state, CX24120_REG_CMD_START, cmd->id);
+	cx24120_writeregs(state, CX24120_REG_CMD_ARGS, &cmd->arg[0],
+			  cmd->len, 1);
+	cx24120_writereg(state, CX24120_REG_CMD_END, 0x01);
 
 	ficus = 1000;
 	while (cx24120_readreg(state, CX24120_REG_CMD_END)) {