From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 23 May 2011 11:09:18 +0000 (-0300)
Subject: [media] Make nchg variable signed because the code compares this variable against... 
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=67e27c741339faedcc8e9c2c613487745d1c4b8b;p=deliverable%2Flinux.git

[media] Make nchg variable signed because the code compares this variable against negative values

The sonixj driver compares the value for nchg with:
 		if (sd->nchg < -6 || sd->nchg >= 12) {

With u8, negative values won't work.

Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
Acked-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
index 6415aff5cbd1..81b8a600783b 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -60,7 +60,7 @@ struct sd {
 
 	u32 pktsz;			/* (used by pkt_scan) */
 	u16 npkt;
-	u8 nchg;
+	s8 nchg;
 	s8 short_mark;
 
 	u8 quality;			/* image quality */