From: Igor Maravic Date: Fri, 25 Nov 2011 07:44:54 +0000 (+0000) Subject: net: Fix skb_update_prio RCU usage. X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=6977a79d36baf8b295b1893621874202e1d02094;p=deliverable%2Flinux.git net: Fix skb_update_prio RCU usage. Change function rcu_dereference to rcu_dereference_bh to avoid warning [ INFO: suspicious RCU usage. ] ------------------------------- net/core/dev.c:2459 suspicious rcu_dereference_check() usage! because we are locking with rcu_read_lock_bh(); in function dev_queue_xmit(struct sk_buff *skb) Signed-off-by: Igor Maravic Signed-off-by: David S. Miller --- diff --git a/net/core/dev.c b/net/core/dev.c index 91a599122074..278463e91e3a 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2473,7 +2473,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q, #if IS_ENABLED(CONFIG_NETPRIO_CGROUP) static void skb_update_prio(struct sk_buff *skb) { - struct netprio_map *map = rcu_dereference(skb->dev->priomap); + struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap); if ((!skb->priority) && (skb->sk) && map) skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx];