From: Dan Carpenter Date: Wed, 6 Jul 2011 18:57:18 +0000 (+0300) Subject: regulator: Storing tps65912 error codes in u8 X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=6daa663dc42957ca6c794a84fe07fa09f0273ff9;p=deliverable%2Flinux.git regulator: Storing tps65912 error codes in u8 get_ctrl_reg() returns -EINVAL so the error handling won't work here if reg is a u8. Signed-off-by: Dan Carpenter Signed-off-by: Samuel Ortiz --- diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c index d2c6542776f1..3a9313e00fac 100644 --- a/drivers/regulator/tps65912-regulator.c +++ b/drivers/regulator/tps65912-regulator.c @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev) struct tps65912_reg *pmic = rdev_get_drvdata(dev); struct tps65912 *mfd = pmic->mfd; int id = rdev_get_id(dev); - u8 reg; + int reg; if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10) return -EINVAL;