From: Gary Benson <gbenson@redhat.com>
Date: Tue, 10 Nov 2020 16:40:40 +0000 (+0000)
Subject: Prevent inlining in gdb.base/vla-optimized-out.c
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=6ff174a7275512ce6f5c7a5496576a0531bd2c2f;p=deliverable%2Fbinutils-gdb.git

Prevent inlining in gdb.base/vla-optimized-out.c

The function f1 in gdb.base/vla-optimized-out.c sets various
attributes to prevent its being inlined, but Clang inlines it
anyway, causing the test that uses it to fail.  This commit
adds the "weak" attribute to cause Clang to keep the function
fully out of line so the test can operate as it should.

gdb/testsuite/ChangeLog:

	* gdb.base/vla-optimized-out.c (f1): Add __attribute__ ((weak)).
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 863dcc4346..146fa1a086 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2020-11-10  Gary Benson <gbenson@redhat.com>
+
+	* gdb.base/vla-optimized-out.c (f1): Add __attribute__ ((weak)).
+
 2020-11-10  Gary Benson <gbenson@redhat.com>
 
 	* gdb.cp/step-and-next-inline.exp: Only require
diff --git a/gdb/testsuite/gdb.base/vla-optimized-out.c b/gdb/testsuite/gdb.base/vla-optimized-out.c
index d21df7a153..1bd4f6d140 100644
--- a/gdb/testsuite/gdb.base/vla-optimized-out.c
+++ b/gdb/testsuite/gdb.base/vla-optimized-out.c
@@ -22,9 +22,9 @@
 
 int
 #ifdef NOCLONE
-__attribute__((noinline)) ATTRIBUTE_NOCLONE
+__attribute__((noinline,weak)) ATTRIBUTE_NOCLONE
 #else
-__attribute__((noinline))
+__attribute__((noinline,weak))
 #endif
 f1 (int i)
 {