From: Jiayi Ye Date: Thu, 23 Oct 2014 14:05:10 +0000 (+0800) Subject: staging: rtl8188eu: core: fix null dereference on exit path in rtw_mlme.c X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=7424a0609063826a60a933ace872a1e747dfeede;p=deliverable%2Flinux.git staging: rtl8188eu: core: fix null dereference on exit path in rtw_mlme.c If adapter is null, null dereference may occur. This patch fixes it. The following Coccinelle semantic patch was used to find the case. @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 Signed-off-by: Jiayi Ye Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c index 149c271e966d..bbebe67a77db 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c @@ -1437,7 +1437,7 @@ void rtw_dynamic_check_timer_handlder(void *function_context) struct registry_priv *pregistrypriv = &adapter->registrypriv; if (!adapter) - goto exit; + return; if (!adapter->hw_init_completed) goto exit; if ((adapter->bDriverStopped) || (adapter->bSurpriseRemoved))