From: Shraddha Barke Date: Fri, 9 Oct 2015 15:33:29 +0000 (+0530) Subject: Staging: rtl8192e: Use kcalloc instead of kzalloc to allocate array X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=749f3c05004ea9bf5b8cfca2c9edd41c764d68c2;p=deliverable%2Flinux.git Staging: rtl8192e: Use kcalloc instead of kzalloc to allocate array The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c index a0d55466888d..113fbf7fbb17 100644 --- a/drivers/staging/rtl8192e/rtllib_module.c +++ b/drivers/staging/rtl8192e/rtllib_module.c @@ -59,9 +59,8 @@ static inline int rtllib_networks_allocate(struct rtllib_device *ieee) if (ieee->networks) return 0; - ieee->networks = kzalloc( - MAX_NETWORK_COUNT * sizeof(struct rtllib_network), - GFP_KERNEL); + ieee->networks = kcalloc(MAX_NETWORK_COUNT, + sizeof(struct rtllib_network), GFP_KERNEL); if (!ieee->networks) return -ENOMEM;