From: Hema Prathaban Date: Sat, 16 Aug 2014 18:57:48 +0000 (+0530) Subject: staging: lustre: lustre: libcfs: do not use assignment in if condition X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=74bb9d4fef9ff789094e85ee1324616611d77baa;p=deliverable%2Flinux.git staging: lustre: lustre: libcfs: do not use assignment in if condition This patch fixes the following error using checkpatch.pl Error: do not use assignment in if condition Signed-off-by: Hema Prathaban Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c index 6b584698d3ae..e86b28d2cb03 100644 --- a/drivers/staging/lustre/lustre/libcfs/debug.c +++ b/drivers/staging/lustre/lustre/libcfs/debug.c @@ -314,9 +314,8 @@ libcfs_debug_str2mask(int *mask, const char *str, int is_subsys) if (!isspace(str[n-1])) break; matched = n; - - if ((t = sscanf(str, "%i%n", &m, &matched)) >= 1 && - matched == n) { + t = sscanf(str, "%i%n", &m, &matched); + if (t >= 1 && matched == n) { /* don't print warning for lctl set_param debug=0 or -1 */ if (m != 0 && m != -1) CWARN("You are trying to use a numerical value for the "