From: Stephen M. Cameron Date: Thu, 29 May 2014 15:53:44 +0000 (-0500) Subject: hpsa: fix event filtering to prevent excessive rescans with old firmware X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=7b2c46ee7259c52cf2c1f82ab100e9aaeb83f78a;p=deliverable%2Flinux.git hpsa: fix event filtering to prevent excessive rescans with old firmware CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL do not require rescans to be initiated. Current firmware filters out these events already, but some out of date firmware doesn't, so the driver needs to filter them out too. Without this change and with out of date firmware you may see the driver spending a lot of time scanning devices unnecessarily on some Smart Arrays. Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Signed-off-by: Christoph Hellwig --- diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 0a5d91c4ded8..24472cec7de3 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -229,11 +229,9 @@ struct ctlr_info { #define CTLR_STATE_CHANGE_EVENT_AIO_CONFIG_CHANGE (1 << 31) #define RESCAN_REQUIRED_EVENT_BITS \ - (CTLR_STATE_CHANGE_EVENT | \ - CTLR_ENCLOSURE_HOT_PLUG_EVENT | \ + (CTLR_ENCLOSURE_HOT_PLUG_EVENT | \ CTLR_STATE_CHANGE_EVENT_PHYSICAL_DRV | \ CTLR_STATE_CHANGE_EVENT_LOGICAL_DRV | \ - CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL | \ CTLR_STATE_CHANGE_EVENT_AIO_ENABLED_DISABLED | \ CTLR_STATE_CHANGE_EVENT_AIO_CONFIG_CHANGE) spinlock_t offline_device_lock;