From: Luis Machado Date: Mon, 26 Oct 2015 13:17:29 +0000 (-0200) Subject: Do not pass NULL for the string in catch_errors X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=7cc53fba0a4e5c316a6e86fdae28f8cc9d0f9a68;p=deliverable%2Fbinutils-gdb.git Do not pass NULL for the string in catch_errors I caught a segmentation fault while running gdb.reverse/sigall-reverse.exp, in a mingw32 GDB, in this code path. It boils down to the code trying to strlen () a NULL pointer. I tracked things down and it looks like record_full_message_wrapper_safe is the only offender. gdb/ChangeLog: 2015-10-26 Luis Machado * record-full.c (record_full_message_wrapper_safe): Pass empty string to catch_errors call instead of NULL. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f26f233f0b..f653a3d72d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2015-10-26 Luis Machado + + * record-full.c (record_full_message_wrapper_safe): Pass empty string to + catch_errors call instead of NULL. + 2015-10-26 Simon Marchi * guile/scm-ports.c (ioscm_make_gdb_stdio_port): Pass non-const diff --git a/gdb/record-full.c b/gdb/record-full.c index cd47dfaa3b..595e357a3b 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -667,7 +667,7 @@ record_full_message_wrapper_safe (struct regcache *regcache, args.regcache = regcache; args.signal = signal; - return catch_errors (record_full_message_wrapper, &args, NULL, + return catch_errors (record_full_message_wrapper, &args, "", RETURN_MASK_ALL); }