From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 5 Mar 2014 10:55:09 +0000 (+0300)
Subject: ALSA: lola: NULL deref on allocation error
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=7cf9bb21ee6df76a3a1eaa512a350cb1af00d544;p=deliverable%2Flinux.git

ALSA: lola: NULL deref on allocation error

"chip" is NULL here.  We don't need a printk here because kmalloc() has
it built in.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/lola/lola.c b/sound/pci/lola/lola.c
index d63434d8c3fb..68824cdd137d 100644
--- a/sound/pci/lola/lola.c
+++ b/sound/pci/lola/lola.c
@@ -586,7 +586,6 @@ static int lola_create(struct snd_card *card, struct pci_dev *pci,
 
 	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
 	if (!chip) {
-		dev_err(chip->card->dev, "cannot allocate chip\n");
 		pci_disable_device(pci);
 		return -ENOMEM;
 	}