From: Dan Carpenter Date: Thu, 3 Apr 2014 19:56:30 +0000 (+1100) Subject: xfs: extra semi-colon breaks a condition X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=805eeb8e04706a16cb0b23fd4c4abbb0bc7df82d;p=deliverable%2Flinux.git xfs: extra semi-colon breaks a condition There were some extra semi-colons here which mean that we return true unintentionally. Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help') Signed-off-by: Dan Carpenter Reviewed-by: Brian Foster Reviewed-by: Eric Sandeen Signed-off-by: Dave Chinner --- diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 5935cce8c26c..dba48853eb10 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -659,10 +659,10 @@ xfs_check_page_type( if (type == XFS_IO_UNWRITTEN) return true; } else if (buffer_delay(bh)) { - if (type == XFS_IO_DELALLOC); + if (type == XFS_IO_DELALLOC) return true; } else if (buffer_dirty(bh) && buffer_mapped(bh)) { - if (type == XFS_IO_OVERWRITE); + if (type == XFS_IO_OVERWRITE) return true; }