From: Linus Walleij Date: Mon, 21 Dec 2015 13:58:52 +0000 (+0100) Subject: gpio: viperboard: Be sure to clamp return value X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=80776df4f53e8e2463e57b7b9bc13298c443a393;p=deliverable%2Flinux.git gpio: viperboard: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Lars Poeschel Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c index 26e7edb74f42..7667e77dd52e 100644 --- a/drivers/gpio/gpio-viperboard.c +++ b/drivers/gpio/gpio-viperboard.c @@ -95,7 +95,7 @@ static int vprbrd_gpioa_get(struct gpio_chip *chip, /* if io is set to output, just return the saved value */ if (gpio->gpioa_out & (1 << offset)) - return gpio->gpioa_val & (1 << offset); + return !!(gpio->gpioa_val & (1 << offset)); mutex_lock(&vb->lock);