From: Pierre Muller <muller@sourceware.org>
Date: Sat, 14 Sep 2013 06:26:35 +0000 (+0000)
Subject: 	* common/filestuff.c (gdb_fopen_cloexec): Do not try to use "e"
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=88505fac1ca9ffbe312908898d62d04d18a9bf47;p=deliverable%2Fbinutils-gdb.git

	* common/filestuff.c (gdb_fopen_cloexec): Do not try to use "e"
	mode if operating system doesn't know O_CLOEXEC.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 54c37abcd4..dd25f6af4d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2013-09-14  Pierre Muller  <muller@sourceware.org>
+	    Tom Tromey  <tromey@redhat.com>
+	    Pedro Alves  <palves@redhat.com>
+
+	* common/filestuff.c (gdb_fopen_cloexec): Do not try to use "e"
+	mode if operating system doesn't know O_CLOEXEC.
+
 2013-09-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Code cleanup.
diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c
index 7d1a69a5a7..d3b13e8c80 100644
--- a/gdb/common/filestuff.c
+++ b/gdb/common/filestuff.c
@@ -311,7 +311,13 @@ FILE *
 gdb_fopen_cloexec (const char *filename, const char *opentype)
 {
   FILE *result = NULL;
-  static int fopen_e_ever_failed;
+  /* Probe for "e" support once.  But, if we can tell the operating
+     system doesn't know about close on exec mode "e" without probing,
+     skip it.  E.g., the Windows runtime issues an "Invalid parameter
+     passed to C runtime function" OutputDebugString warning for
+     unknown modes.  Assume that if O_CLOEXEC is zero, then "e" isn't
+     supported.  */
+  static int fopen_e_ever_failed = O_CLOEXEC == 0;
 
   if (!fopen_e_ever_failed)
     {