From: Dan Carpenter Date: Wed, 13 Jul 2016 10:12:34 +0000 (+0300) Subject: hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=8a545f185145e3c09348cd74326268ecfc6715a3;p=deliverable%2Flinux.git hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common() We can't pass error pointers to kfree() or it causes an oops. Fixes: 52b209f7b848 ('get rid of hostfs_read_inode()') Signed-off-by: Dan Carpenter Signed-off-by: Richard Weinberger --- diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index 5c57654927a6..90e46cd752fe 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -959,10 +959,11 @@ static int hostfs_fill_sb_common(struct super_block *sb, void *d, int silent) if (S_ISLNK(root_inode->i_mode)) { char *name = follow_link(host_root_path); - if (IS_ERR(name)) + if (IS_ERR(name)) { err = PTR_ERR(name); - else - err = read_name(root_inode, name); + goto out_put; + } + err = read_name(root_inode, name); kfree(name); if (err) goto out_put;