From: Devendra Naga Date: Tue, 12 Mar 2013 05:34:45 +0000 (-0400) Subject: staging: et131x: fix invalid fail after the call to eeprom_wait_ready X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=8dd4a9665280eafc042d6420f6a21bf0d20c19d9;p=deliverable%2Flinux.git staging: et131x: fix invalid fail after the call to eeprom_wait_ready should be err < 0 instead of if (err) which actually the read register value can be a positive number Acked-by: Mark Einon Signed-off-by: Devendra Naga Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 42ae5e83f907..c7e9e1d6bf70 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -595,7 +595,7 @@ static int eeprom_write(struct et131x_adapter *adapter, u32 addr, u8 data) */ err = eeprom_wait_ready(pdev, NULL); - if (err) + if (err < 0) return err; /* 2. Write to the LBCIF Control Register: bit 7=1, bit 6=1, bit 3=0, @@ -709,7 +709,7 @@ static int eeprom_read(struct et131x_adapter *adapter, u32 addr, u8 *pdata) */ err = eeprom_wait_ready(pdev, NULL); - if (err) + if (err < 0) return err; /* Write to the LBCIF Control Register: bit 7=1, bit 6=0, bit 3=0, * and bits 1:0 both =0. Bit 5 should be set according to the type