From: Tom Tromey <tom@tromey.com>
Date: Sun, 16 Jun 2019 21:17:52 +0000 (-0600)
Subject: Remove redundant check from make_visible
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=8e2daf1532e587fee8d14aab1baad40e628065e2;p=deliverable%2Fbinutils-gdb.git

Remove redundant check from make_visible

This removes a check of the window type from make_visible.  This
function already checks that the window type is not CMD_WIN near the
top, so this condition can never be false.

gdb/ChangeLog
2019-06-25  Tom Tromey  <tom@tromey.com>

	* tui/tui-wingeneral.c (make_visible): Remove check of window
	type.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 174d12b8fa..0d66374687 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-06-25  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-wingeneral.c (make_visible): Remove check of window
+	type.
+
 2019-06-25  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-win.c (tui_win_info::max_height)
diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index 4d168af0c0..73d77ce19f 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -181,9 +181,7 @@ make_visible (struct tui_gen_win_info *win_info, bool visible)
     {
       if (!win_info->is_visible)
 	{
-	  tui_make_window (win_info,
-			   (win_info->type != CMD_WIN
-			    && !tui_win_is_auxillary (win_info->type)));
+	  tui_make_window (win_info, !tui_win_is_auxillary (win_info->type));
 	  win_info->is_visible = true;
 	}
     }