From: Jie Liu Date: Thu, 24 Jul 2014 01:33:28 +0000 (+1000) Subject: xfs: remove redundant stat assignment in xfs_bulkstat_one_int X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=8fe657760d5c8372cd4cf022c4cdb9307a3af995;p=deliverable%2Flinux.git xfs: remove redundant stat assignment in xfs_bulkstat_one_int From: Jie Liu Remove the redundant BULKSTAT_RV_NOTHING assignment in case of call xfs_iget() failed at xfs_bulkstat_one_int(). Signed-off-by: Jie Liu Reviewed-by: Christoph Hellwig Signed-off-by: Dave Chinner --- diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c index 7e54992bcae9..ca15214f1772 100644 --- a/fs/xfs/xfs_itable.c +++ b/fs/xfs/xfs_itable.c @@ -76,10 +76,8 @@ xfs_bulkstat_one_int( error = xfs_iget(mp, NULL, ino, (XFS_IGET_DONTCACHE | XFS_IGET_UNTRUSTED), XFS_ILOCK_SHARED, &ip); - if (error) { - *stat = BULKSTAT_RV_NOTHING; + if (error) goto out_free; - } ASSERT(ip != NULL); ASSERT(ip->i_imap.im_blkno != 0); @@ -136,7 +134,6 @@ xfs_bulkstat_one_int( IRELE(ip); error = formatter(buffer, ubsize, ubused, buf); - if (!error) *stat = BULKSTAT_RV_DIDONE;