From: Kent Overstreet <koverstreet@google.com>
Date: Fri, 5 Apr 2013 21:12:28 +0000 (-0700)
Subject: bcache: Fix a format string overflow
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=91bbcfc36142354e316e013449051619c1c7b456;p=deliverable%2Flinux.git

bcache: Fix a format string overflow

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kent Overstreet <koverstreet@google.com>
---

diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c
index a9619d880354..da3a99e85b1e 100644
--- a/drivers/md/bcache/util.c
+++ b/drivers/md/bcache/util.c
@@ -76,7 +76,7 @@ STRTO_H(strtoull, unsigned long long)
 ssize_t bch_hprint(char *buf, int64_t v)
 {
 	static const char units[] = "?kMGTPEZY";
-	char dec[3] = "";
+	char dec[4] = "";
 	int u, t = 0;
 
 	for (u = 0; v >= 1024 || v <= -1024; u++) {
@@ -88,7 +88,7 @@ ssize_t bch_hprint(char *buf, int64_t v)
 		return sprintf(buf, "%llu", v);
 
 	if (v < 100 && v > -100)
-		sprintf(dec, ".%i", t / 100);
+		snprintf(dec, sizeof(dec), ".%i", t / 100);
 
 	return sprintf(buf, "%lli%s%c", v, dec, units[u]);
 }