From: Beniamino Galvani Date: Fri, 5 Sep 2014 22:28:23 +0000 (+0200) Subject: net: phy: mdio-sun4i: don't select REGULATOR X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=97a13e5289baa96eaddd06e61d277457d837af3a;p=deliverable%2Flinux.git net: phy: mdio-sun4i: don't select REGULATOR The mdio-sun4i driver automatically selects REGULATOR and REGULATOR_FIXED_VOLTAGE because it uses the regulator API. But a driver selecting a subsystem increases the chance of generating circular Kconfig dependencies, especially when other drivers depend on the selected symbol. Since the regulator API functions are replaced with no-ops when REGULATOR is disabled, the driver can be built successfully even without regulator support and so those 'select' dependencies can be safely dropped. Suggested-by: Arnd Bergmann Signed-off-by: Beniamino Galvani Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 28437ab9c7bd..14afa4f24424 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -159,8 +159,6 @@ config MDIO_OCTEON config MDIO_SUN4I tristate "Allwinner sun4i MDIO interface support" depends on ARCH_SUNXI - select REGULATOR - select REGULATOR_FIXED_VOLTAGE help This driver supports the MDIO interface found in the network interface units of the Allwinner SoC that have an EMAC (A10,