From: H Hartley Sweeten Date: Thu, 23 May 2013 19:54:06 +0000 (-0700) Subject: staging: comedi: usbduxsigma: remove unnecessary check in usbdux_ao_cmd() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=982d255b3e5d5945b91a84b019841736bcee96dc;p=deliverable%2Flinux.git staging: comedi: usbduxsigma: remove unnecessary check in usbdux_ao_cmd() The comedi core verifies that the command chanlist_len is valid for the subdevice based on the len_chanlist that was setup during the attach. There is no need to recheck it in the (*cmd) function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index dab1a3cf3fcd..e9dfbb3e7de3 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c @@ -1189,12 +1189,6 @@ static int usbdux_ao_cmd(struct comedi_device *dev, struct comedi_subdevice *s) for (i = 0; i < cmd->chanlist_len; ++i) { chan = CR_CHAN(cmd->chanlist[i]); gain = CR_RANGE(cmd->chanlist[i]); - if (i >= NUMOUTCHANNELS) { - dev_err(&this_usbduxsub->interface->dev, - "comedi%d: %s: channel list too long\n", - dev->minor, __func__); - break; - } this_usbduxsub->dac_commands[i] = chan; dev_dbg(&this_usbduxsub->interface->dev, "comedi%d: dac command for ch %d is %x\n",