From: Alan Modra <amodra@gmail.com>
Date: Tue, 31 Dec 2019 23:58:42 +0000 (+1030)
Subject: coff: free malloc'd memory on successful target match too
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=991fb595e34598291a52b533fdc8005e1ead0799;p=deliverable%2Fbinutils-gdb.git

coff: free malloc'd memory on successful target match too

object_p functions cannot allocate memory by malloc and not free it
before returning.  Even a successful target match may not be the best
match.  If a match isn't used then those malloc'd blocks won't be
freed.

	* coffgen.c (coff_real_object_p): Free malloc'd memory on target
	match too.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 0ad28a798d..6d19839fec 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-04  Alan Modra  <amodra@gmail.com>
+
+	* coffgen.c (coff_real_object_p): Free malloc'd memory on target
+	match too.
+
 2020-01-03  Nick Clifton  <nickc@redhat.com>
 
 	PR 25307
diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 68b81ec588..2bfcf1a6b1 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -302,6 +302,9 @@ coff_real_object_p (bfd *abfd,
 	}
     }
 
+  obj_coff_keep_syms (abfd) = FALSE;
+  obj_coff_keep_strings (abfd) = FALSE;
+  _bfd_coff_free_symbols (abfd);
   return abfd->xvec;
 
  fail: