From: Guenter Roeck <linux@roeck-us.net>
Date: Wed, 12 Feb 2014 05:34:21 +0000 (-0800)
Subject: hwmon: (emc2103) Return error from i2c_smbus_read_byte_data
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=9bf3babf3f6e70723528bece564c57d38d534652;p=deliverable%2Flinux.git

hwmon: (emc2103) Return error from i2c_smbus_read_byte_data

There is no reason to replace one error with another.

smatch message:
drivers/hwmon/emc2103.c:352 set_fan_div() info: why not propagate 'status'
from i2c_smbus_read_byte_data() instead of (-5)?

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmon/emc2103.c
index 2c137b26acb4..fd892dd48e4c 100644
--- a/drivers/hwmon/emc2103.c
+++ b/drivers/hwmon/emc2103.c
@@ -349,7 +349,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *da,
 		dev_dbg(&client->dev, "reg 0x%02x, err %d\n",
 			REG_FAN_CONF1, status);
 		mutex_unlock(&data->update_lock);
-		return -EIO;
+		return status;
 	}
 	status &= 0x9F;
 	status |= (new_range_bits << 5);