From: Jérémie Galarneau Date: Wed, 16 Mar 2022 21:35:43 +0000 (-0400) Subject: Fix: sessiond: ust-app: uninitialized name logged on stream copy failure X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=9ee61e743b098eb111e97163ce9939ac62947dd7;p=deliverable%2Flttng-tools.git Fix: sessiond: ust-app: uninitialized name logged on stream copy failure 1466302 Uninitialized scalar variable The variable will contain an arbitrary value left from earlier computations. In send_channel_uid_to_ust(buffer_reg_channel *, ust_app *, ust_app_session *, ust_app_channel *): Use of an uninitialized variable (CWE-457) Signed-off-by: Jérémie Galarneau Change-Id: Icd38de3b67dab783fa26a721c68c48ebfbb59785 --- diff --git a/src/bin/lttng-sessiond/ust-app.cpp b/src/bin/lttng-sessiond/ust-app.cpp index 1ae2bbac3..1006f7f64 100644 --- a/src/bin/lttng-sessiond/ust-app.cpp +++ b/src/bin/lttng-sessiond/ust-app.cpp @@ -3319,7 +3319,7 @@ static int send_channel_uid_to_ust(struct buffer_reg_channel *buf_reg_chan, /* Send all streams to application. */ pthread_mutex_lock(&buf_reg_chan->stream_list_lock); cds_list_for_each_entry(reg_stream, &buf_reg_chan->streams, lnode) { - struct ust_app_stream stream; + struct ust_app_stream stream = {}; ret = duplicate_stream_object(reg_stream, &stream); if (ret < 0) { @@ -3336,8 +3336,8 @@ static int send_channel_uid_to_ust(struct buffer_reg_channel *buf_reg_chan, * Treat this the same way as an application * that is exiting. */ - WARN("Communication with application %d timed out on send_stream for stream \"%s\" of channel \"%s\" of session \"%" PRIu64 "\".", - app->pid, stream.name, + WARN("Communication with application %d timed out on send_stream for stream of channel \"%s\" of session \"%" PRIu64 "\".", + app->pid, ua_chan->name, ua_sess->tracing_id); ret = -ENOTCONN;